]> Cypherpunks repositories - gostls13.git/commit
runtime/trace: fix broken TestSubscribers
authorMichael Anthony Knyszek <mknyszek@google.com>
Thu, 11 Dec 2025 18:02:36 +0000 (18:02 +0000)
committerMichael Knyszek <mknyszek@google.com>
Thu, 11 Dec 2025 18:37:14 +0000 (10:37 -0800)
commit89614ad264803558cfa36d460d431f7cbd4bae47
treee3997129ada427ea6921ea71728b3b5ed65dbf75
parentbb2337f24c8d774ef122e2251f02c5e512c77a55
runtime/trace: fix broken TestSubscribers

Currently we don't break out of the loop on a failure. This is
leading to timeouts trying to parse a broken trace over and over,
forever.

But there's another issue where when we try to dump the trace, we pass
only the unread portion of the bytes.Buffer.

Change-Id: I1a338eea08eaf7f592fb7dd2a736a6fe0728c62d
Reviewed-on: https://go-review.googlesource.com/c/go/+/729320
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/runtime/trace/subscribe_test.go