]> Cypherpunks repositories - gostls13.git/commit
net: fix socket duplication error handling on Windows
authorqmuntal <quimmuntal@gmail.com>
Thu, 8 Jan 2026 14:50:15 +0000 (15:50 +0100)
committerQuim Muntal <quimmuntal@gmail.com>
Mon, 12 Jan 2026 19:53:11 +0000 (11:53 -0800)
commitcbe153806e67a16e362a1cdbbf1741d4ce82e98a
treed79fd08a98364dd2b52961388168fc805ab54bd1
parent30d0b4026410da3486ba841bb7f13c1d9074e91d
net: fix socket duplication error handling on Windows

Calls to dupSocket may fail, but the error is not properly handled
because the surrounding code incorrectly checks for nil error instead
of non-nil error.

I'm not aware of any code paths that would trigger this error, and
I haven't been able to create a test case that does so, but this
change fixes the error handling to correctly propagate any errors
from dupSocket.

Change-Id: I5ffd3cbe8ed58a83634f3b97c0878a7c73e0505e
Reviewed-on: https://go-review.googlesource.com/c/go/+/734821
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
src/net/fd_windows.go
src/net/file_windows.go