]> Cypherpunks repositories - gostls13.git/commit
runtime/trace: dump test traces on validation failure
authorMichael Anthony Knyszek <mknyszek@google.com>
Thu, 9 Oct 2025 20:30:18 +0000 (20:30 +0000)
committerGopher Robot <gobot@golang.org>
Tue, 21 Oct 2025 01:11:06 +0000 (18:11 -0700)
commitee4d2c312de90296a6b6f687f6a7ea8b9916af54
treea544b18bbafe093c2c18a7fc0b136e643db88f03
parent7b81a1e1077dfcddc2c80113dff0a2c3cbde35ae
runtime/trace: dump test traces on validation failure

We currently dump traces for internal/trace tests on validation failure,
but not for the runtime/trace package.

This change moves some of the machinery to do this into the testtrace
package and then uses it from the runtime/trace package.

For #75665.

Change-Id: Ibe2d4f3945c1fd21dcbccf56820865f8d2ea41f9
Reviewed-on: https://go-review.googlesource.com/c/go/+/710755
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/go/build/deps_test.go
src/internal/trace/reader_test.go
src/internal/trace/testtrace/helpers.go [new file with mode: 0644]
src/internal/trace/trace_test.go
src/runtime/trace/flightrecorder_test.go
src/runtime/trace/trace_test.go