]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: don't rely on loop info when there are irreducible loops
authorKeith Randall <khr@golang.org>
Tue, 23 Sep 2025 23:31:26 +0000 (16:31 -0700)
committerKeith Randall <khr@google.com>
Wed, 24 Sep 2025 22:24:36 +0000 (15:24 -0700)
commitf15cd63ec4860c4f2c23cc992843546e0265c332
tree3ff839dd32bd84b01758066d72f8386b7d6aff29
parent371c1d2fcb48fa79ac30812231ecef0e26f539dc
cmd/compile: don't rely on loop info when there are irreducible loops

Loop information is sketchy when there are irreducible loops.
Sometimes blocks inside 2 loops can be recorded as only being part of
the outer loop. That causes tighten to move values that want to move
into such a block to move out of the loop altogether, breaking the
invariant that operations have to be scheduled after their args.

Fixes #75569

Change-Id: Idd80e6d2268094b8ae6387563081fdc1e211856a
Reviewed-on: https://go-review.googlesource.com/c/go/+/706355
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
src/cmd/compile/internal/ssa/tighten.go
test/fixedbugs/issue75569.go [new file with mode: 0644]