compress/bzip2: use obscuretestdata.ReadFile to avoid creating temporary

The temporary was not being deleted. Not creating it at all is better.

Change-Id: Id9c5498a2f7d2f58770a09a2a76f4ab30943dd3d
Reviewed-on: https://go-review.googlesource.com/c/go/+/740780
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Joseph Tsai <joetsai@digital-static.net>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

diff --git a/src/compress/bzip2/bzip2_test.go b/src/compress/bzip2/bzip2_test.go
index 13e2d3c1fa94e2800cf06b6c4b832c90c3ab457d..7473aac7a91d9b4c174d35a6d02bcd309121e187 100644 (file)
--- a/src/compress/bzip2/bzip2_test.go
+++ b/src/compress/bzip2/bzip2_test.go
@@ -25,11 +25,11 @@ func mustDecodeHex(s string) []byte {
 
 func mustLoadFile(f string) []byte {
        if strings.HasSuffix(f, ".base64") {
-               tf, err := obscuretestdata.DecodeToTempFile(f)
+               b, err := obscuretestdata.ReadFile(f)
                if err != nil {
-                       panic(fmt.Sprintf("obscuretestdata.DecodeToTempFile(%s): %v", f, err))
+                       panic(fmt.Sprintf("obscuretestdata.ReadFile(%s): %v", f, err))
                }
-               f = tf
+               return b
        }
 
        b, err := os.ReadFile(f)