]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.26] cmd/link: don't pass -Wl,-S on illumos
authorPeter Tribble <peter.tribble@gmail.com>
Wed, 18 Feb 2026 14:24:18 +0000 (14:24 +0000)
committerGopher Robot <gobot@golang.org>
Wed, 18 Feb 2026 18:43:22 +0000 (10:43 -0800)
The change in CL 707096 to exclude GOOS=solaris needs to also be applied
for GOOS=illumos, which shares the same linker lineage.

Fixes #77680

Change-Id: Ifc2047595af2db52870f9fb0a9faf646666d9e61
Reviewed-on: https://go-review.googlesource.com/c/go/+/746560
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Mark Freeman <markfreeman@google.com>
(cherry picked from commit 50b63f6cb90a1437ca6756ede016f1918e721da6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/746660
Reviewed-by: Junyang Shao <shaojunyang@google.com>
Auto-Submit: Mark Freeman <markfreeman@google.com>

src/cmd/link/dwarf_test.go

index 3900ae065457caf70c105db696d9a58e9da2d76b..9d41c55b261bd4edf227eacab02e5b1c6e6f3b1b 100644 (file)
@@ -426,7 +426,7 @@ func TestFlagW(t *testing.T) {
                {"-s", false},     // -s implies -w
                {"-s -w=0", true}, // -w=0 negates the implied -w
        }
-       if testenv.HasCGO() && runtime.GOOS != "solaris" { // Solaris linker doesn't support the -S flag
+       if testenv.HasCGO() && runtime.GOOS != "solaris" && runtime.GOOS != "illumos" { // Solaris linker doesn't support the -S flag
                tests = append(tests,
                        testCase{"-w -linkmode=external", false},
                        testCase{"-s -linkmode=external", false},