]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: disable TestNotInGoMetricCallback on FreeBSD + race
authorMichael Anthony Knyszek <mknyszek@google.com>
Mon, 8 Dec 2025 16:05:53 +0000 (16:05 +0000)
committerGopher Robot <gobot@golang.org>
Mon, 8 Dec 2025 16:24:40 +0000 (08:24 -0800)
cgo + race is not supported on FreeBSD.

Change-Id: I38abeccaaabfcc104d1d5a077fb99646dc4be792
Reviewed-on: https://go-review.googlesource.com/c/go/+/728120
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/runtime/metrics_test.go
src/runtime/testdata/testprogcgo/notingo.go

index efd2c2adb9bd851407e148c8fc2d0f5c794b6ef7..278efdc69f8345ed79001c3bc414934b71d5d1e4 100644 (file)
@@ -9,6 +9,7 @@ import (
        "internal/abi"
        "internal/goexperiment"
        "internal/profile"
+       "internal/race"
        "internal/testenv"
        "os"
        "reflect"
@@ -1589,6 +1590,10 @@ func TestNotInGoMetricCallback(t *testing.T) {
        switch runtime.GOOS {
        case "windows", "plan9":
                t.Skip("unsupported on Windows and Plan9")
+       case "freebsd":
+               if race.Enabled {
+                       t.Skipf("race + cgo freebsd not supported. See https://go.dev/issue/73788.")
+               }
        }
 
        // This test is run in a subprocess to prevent other tests from polluting the metrics
index 6e781263586a72004c6103709690e09bed7c7c3d..5af4c00e1fb9c26bbae4ab373b19dcee7b7e4a13 100644 (file)
@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build !plan9 && !windows
-// +build !plan9,!windows
 
 package main