]> Cypherpunks repositories - gostls13.git/commitdiff
runtime/race: set missing argument frame for ppc64x atomic And/Or wrappers
authorJayanth Krishnamurthy jayanth.krishnamurthy@ibm.com <jayanth.krishnamurthy@ibm.com>
Thu, 6 Nov 2025 19:43:45 +0000 (13:43 -0600)
committerKeith Randall <khr@golang.org>
Fri, 5 Dec 2025 19:22:36 +0000 (11:22 -0800)
The ppc64x TSAN wrappers for atomic And/Or did not initialize R6 with the Go argument frame before calling racecallatomic. Since racecallatomic expects R6 to point to the argument list and dereferences it unconditionally, this led to a nil-pointer dereference under -race.

Other atomic TSAN wrappers (Load/Store/Add/Swap/CAS) already set up R6 in the expected way. This change aligns the And/Or wrappers with the rest by adding the missing R6 initialisation.

This keeps the behavior consistent across all atomic operations on ppc64x.

Fixes #76051.
Change-Id: Iaf578449a6171a0c6f7c33ec6f64c1251297ae6d
Cq-Include-Trybots: luci.golang.try:gotip-linux-ppc64_power10,gotip-linux-ppc64_power8,gotip-linux-ppc64le_power8,gotip-linux-ppc64le_power9,gotip-linux-ppc64le_power10
Reviewed-on: https://go-review.googlesource.com/c/go/+/718560
Reviewed-by: Mark Freeman <markfreeman@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Paul Murphy <paumurph@redhat.com>
src/runtime/race_ppc64le.s

index b327e49a2f181ea576ebf1b96af1f6fafe8fda3b..41cd232392e5641b7429b9690daa79f195eb0e7f 100644 (file)
@@ -329,11 +329,13 @@ TEXT      sync∕atomic·AddUintptr(SB), NOSPLIT, $0-24
 TEXT   sync∕atomic·AndInt32(SB), NOSPLIT, $0-20
        GO_ARGS
        MOVD    $__tsan_go_atomic32_fetch_and(SB), R8
+       ADD     $32, R1, R6
        BR      racecallatomic<>(SB)
 
 TEXT   sync∕atomic·AndInt64(SB), NOSPLIT, $0-24
        GO_ARGS
        MOVD    $__tsan_go_atomic64_fetch_and(SB), R8
+       ADD     $32, R1, R6
        BR      racecallatomic<>(SB)
 
 TEXT   sync∕atomic·AndUint32(SB), NOSPLIT, $0-20
@@ -352,11 +354,13 @@ TEXT      sync∕atomic·AndUintptr(SB), NOSPLIT, $0-24
 TEXT   sync∕atomic·OrInt32(SB), NOSPLIT, $0-20
        GO_ARGS
        MOVD    $__tsan_go_atomic32_fetch_or(SB), R8
+       ADD     $32, R1, R6
        BR      racecallatomic<>(SB)
 
 TEXT   sync∕atomic·OrInt64(SB), NOSPLIT, $0-24
        GO_ARGS
        MOVD    $__tsan_go_atomic64_fetch_or(SB), R8
+       ADD     $32, R1, R6
        BR      racecallatomic<>(SB)
 
 TEXT   sync∕atomic·OrUint32(SB), NOSPLIT, $0-20