]> Cypherpunks repositories - gostls13.git/commitdiff
reflect: remove stale comment in unpackEface
authorMateusz Poliwczak <mpoliwczak34@gmail.com>
Sat, 20 Sep 2025 06:14:49 +0000 (08:14 +0200)
committerMateusz Poliwczak <mpoliwczak34@gmail.com>
Tue, 23 Sep 2025 18:47:57 +0000 (11:47 -0700)
e.word (or more properly e.Data) is always a pointer now.

Change-Id: I6a6a6964b17797e234829691ced842ab431ec38f
Reviewed-on: https://go-review.googlesource.com/c/go/+/705535
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

src/reflect/value.go

index 818eacf9cf37f243d9c22f4523ae364607604b1a..c0ac45de77be85d939132dfb63f6f1192dd9f5a3 100644 (file)
@@ -156,7 +156,6 @@ func packEfaceData(v Value) unsafe.Pointer {
 // unpackEface converts the empty interface i to a Value.
 func unpackEface(i any) Value {
        e := (*abi.EmptyInterface)(unsafe.Pointer(&i))
-       // NOTE: don't read e.word until we know whether it is really a pointer or not.
        t := e.Type
        if t == nil {
                return Value{}