]> Cypherpunks repositories - gostls13.git/commitdiff
[dev.simd] cmd/compile: flip sense of intrinsics test for SIMD
authorDavid Chase <drchase@google.com>
Fri, 30 May 2025 15:39:02 +0000 (11:39 -0400)
committerGopher Robot <gobot@golang.org>
Fri, 30 May 2025 16:14:44 +0000 (09:14 -0700)
ENABLE when simd experiment is off, to be sure intrinsics
do not leak past the experiment.

DISABLE when simd is on, because all this does is cause tests to
fail, then whoever failed the test regenerates the simd, doesn't look
at the mountain of new intrinsics, and just rubber-stamps the change.
All friction, no benefit.

Change-Id: I2ef7e0c246aaddd4a52c1d6108cb587adc1b8366
Reviewed-on: https://go-review.googlesource.com/c/go/+/677555
Auto-Submit: Junyang Shao <shaojunyang@google.com>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

src/cmd/compile/internal/ssagen/intrinsics_test.go

index bd9dd616fd8c684125b783675141e9ce4f4463ff..6c7e65abfd46105acb65fa637af06c223f99738e 100644 (file)
@@ -16,7 +16,10 @@ import (
 )
 
 var updateIntrinsics = flag.Bool("update", false, "Print an updated intrinsics table")
-var simd = flag.Bool("simd", buildcfg.Experiment.SIMD, "Also check SIMD intrinsics; defaults to GOEXPERIMENT==simd")
+
+// TODO turn on always.  Current setting insures that simd intrinsics do not leak past experiment,
+// but also avoids fail+rubber-stamp-update friction while SIMD is under active development.
+var simd = flag.Bool("simd", !buildcfg.Experiment.SIMD, "Also check SIMD intrinsics; default to GOEXPERIMENT = NO simd")
 
 type testIntrinsicKey struct {
        archName string