]> Cypherpunks repositories - gostls13.git/commitdiff
net: remove unnecessary loop variable copies in tests
authorPlamerdi Makela <plamerdi447@gmail.com>
Tue, 11 Nov 2025 15:10:53 +0000 (15:10 +0000)
committerGopher Robot <gobot@golang.org>
Fri, 21 Nov 2025 20:40:21 +0000 (12:40 -0800)
Similar to CL 711640.

Change-Id: I5cd9470138c80094eeb497cf4652d6a29cd795a6
GitHub-Last-Rev: 603fb5f4d55a12a773f2cb08b295578fb45ad14e
GitHub-Pull-Request: golang/go#76253
Reviewed-on: https://go-review.googlesource.com/c/go/+/719600
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Mark Freeman <markfreeman@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
src/net/lookup_windows_test.go
src/net/unixsock_windows_test.go
src/net/url/url_test.go

index 4f287901855653f65570b826d541b887b5fe8f9c..bee1a6150c30d479867401c813574eab082ee6dc 100644 (file)
@@ -30,9 +30,7 @@ func toJson(v any) string {
 
 func testLookup(t *testing.T, fn func(*testing.T, *Resolver, string)) {
        for _, def := range []bool{true, false} {
-               def := def
                for _, server := range nslookupTestServers {
-                       server := server
                        var name string
                        if def {
                                name = "default/"
index 4c1a8d7e7e04c06c004b35f7dac13fc8757cf0d1..b7ed932b14e8355a78550777dba04508aaac29ae 100644 (file)
@@ -20,7 +20,6 @@ func TestUnixConnLocalWindows(t *testing.T) {
        }
        handler := func(ls *localServer, ln Listener) {}
        for _, laddr := range []string{"", testUnixAddr(t)} {
-               laddr := laddr
                taddr := testUnixAddr(t)
                ta, err := ResolveUnixAddr("unix", taddr)
                if err != nil {
index a70b94b424567d8201e2398ba2969b45afd09fd7..3ced91fc4c08368a55710a288e0331d5c226ebc9 100644 (file)
@@ -880,7 +880,6 @@ func TestURLRedacted(t *testing.T) {
        }
 
        for _, tt := range cases {
-               t := t
                t.Run(tt.name, func(t *testing.T) {
                        if g, w := tt.url.Redacted(), tt.want; g != w {
                                t.Fatalf("got: %q\nwant: %q", g, w)