]> Cypherpunks repositories - gostls13.git/commitdiff
crypto/internal/fips140: update frozen module version to "v1.0.0"
authorFilippo Valsorda <filippo@golang.org>
Sun, 7 Sep 2025 14:37:40 +0000 (16:37 +0200)
committerGopher Robot <gobot@golang.org>
Tue, 9 Sep 2025 19:23:21 +0000 (12:23 -0700)
We are re-sealing the .zip file anyway for another reason, might as well
take the opportunity to fix the "v1.0" mistake.

Change-Id: I6a6a69646b3188984c865031ff9393ccaaaa9479
Reviewed-on: https://go-review.googlesource.com/c/go/+/701518
Reviewed-by: Daniel McCarney <daniel@binaryparadox.net>
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Mark Freeman <markfreeman@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
src/crypto/internal/cryptotest/hash.go
src/crypto/internal/fips140/fips140.go
src/crypto/internal/fips140test/fips_test.go

index f00e9c80d3c86af03757960e37749d6d458dbbd8..37fd96a2d9d0b9ef879f7a9eab22eeb2b25f90d0 100644 (file)
@@ -20,7 +20,7 @@ type MakeHash func() hash.Hash
 // TestHash performs a set of tests on hash.Hash implementations, checking the
 // documented requirements of Write, Sum, Reset, Size, and BlockSize.
 func TestHash(t *testing.T, mh MakeHash) {
-       if boring.Enabled || fips140.Version() == "v1.0" {
+       if boring.Enabled || fips140.Version() == "v1.0.0" {
                testhash.TestHashWithoutClone(t, testhash.MakeHash(mh))
                return
        }
index fd265718e026c5436176e10ef2d67d4d21ea8f51..79dda605fecc70799202426a8aad51011f2e259b 100644 (file)
@@ -62,7 +62,7 @@ func Name() string {
        return "Go Cryptographic Module"
 }
 
-// Version returns the formal version (such as "v1.0") if building against a
+// Version returns the formal version (such as "v1.0.0") if building against a
 // frozen module with GOFIPS140. Otherwise, it returns "latest".
 func Version() string {
        // This return value is replaced by mkzip.go, it must not be changed or
index 08d60933ef38b8dad6da6f5df06cf326e8ee24f9..6220e536f4aa6eb6c327ecbd7d7b83a62de87674 100644 (file)
@@ -74,11 +74,6 @@ func TestVersion(t *testing.T) {
                        continue
                }
                exp := setting.Value
-               if exp == "v1.0.0" {
-                       // Unfortunately we enshrined the version of the first module as
-                       // v1.0 before deciding to go for full versions.
-                       exp = "v1.0"
-               }
                if v := fips140.Version(); v != exp {
                        t.Errorf("Version is %q, expected %q", v, exp)
                }