]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: include stderr when objdump fails
authorMichael Pratt <mpratt@google.com>
Tue, 16 Sep 2025 19:07:08 +0000 (15:07 -0400)
committerGopher Robot <gobot@golang.org>
Fri, 19 Sep 2025 19:34:15 +0000 (12:34 -0700)
If objdump panics, we want the panic included in the test log.

Change-Id: I6a6a636c13c5ba08acaa1c6c8714541a8e91542b
Reviewed-on: https://go-review.googlesource.com/c/go/+/704338
Reviewed-by: Florian Lehner <lehner.florian86@gmail.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

src/runtime/unsafepoint_test.go

index 2c97adead8929efec6c3d24516043942fbf8fdb4..79f0171854191f939202d12d4158990a5a8bb362 100644 (file)
@@ -43,7 +43,7 @@ func TestUnsafePoint(t *testing.T) {
        cmd := exec.Command(testenv.GoToolPath(t), "tool", "objdump", "-s", "setGlobalPointer", os.Args[0])
        out, err := cmd.CombinedOutput()
        if err != nil {
-               t.Fatalf("can't objdump %v", err)
+               t.Fatalf("can't objdump %v:\n%s", err, out)
        }
        lines := strings.Split(string(out), "\n")[1:]