all: delete remaining windows/arm code

Fixes #43800
Updates #71671

Change-Id: Ib7aafe3a3f6ae48f23fa23f03103820e9fcf5161
Reviewed-on: https://go-review.googlesource.com/c/go/+/698415
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>

diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index aa09d1eba34be883ab053597788b27f958c7d534..5f3a66ed042d7b888fa7110da538d0819ac1c936 100644 (file)
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -1773,7 +1773,7 @@ func buildModeSupported(compiler, buildmode, goos, goarch string) bool {
                        "ios/amd64", "ios/arm64",
                        "aix/ppc64",
                        "openbsd/arm64",
-                       "windows/386", "windows/amd64", "windows/arm", "windows/arm64":
+                       "windows/386", "windows/amd64", "windows/arm64":
                        return true
                }
                return false

diff --git a/src/cmd/internal/obj/fips140.go b/src/cmd/internal/obj/fips140.go
index ea36849a21d96d96eadf0b1b645953eaa8c57b0a..da18b641786718a92852610e1996dd835ddb8eac 100644 (file)
--- a/src/cmd/internal/obj/fips140.go
+++ b/src/cmd/internal/obj/fips140.go
@@ -196,14 +196,8 @@ func EnableFIPS() bool {
        // Perhaps the default should be changed back to -buildmode=exe,
        // after which we could remove this case, but until then,
        // skip FIPS on windows-386.
-       //
-       // We don't know whether arm works, because it is too hard to get builder
-       // time to test it. Disable since it's not important right now.
-       if buildcfg.GOOS == "windows" {
-               switch buildcfg.GOARCH {
-               case "386", "arm":
-                       return false
-               }
+       if buildcfg.GOOS == "windows" && buildcfg.GOARCH == "386" {
+               return false
        }
 
        // AIX doesn't just work, and it's not worth fixing.

diff --git a/src/crypto/internal/fips140/fips140.go b/src/crypto/internal/fips140/fips140.go
index 050967f4808ad657252cc47c26ac89da2d924656..fd265718e026c5436176e10ef2d67d4d21ea8f51 100644 (file)
--- a/src/crypto/internal/fips140/fips140.go
+++ b/src/crypto/internal/fips140/fips140.go
@@ -46,7 +46,6 @@ func Supported() error {
        switch {
        case runtime.GOARCH == "wasm",
                runtime.GOOS == "windows" && runtime.GOARCH == "386",
-               runtime.GOOS == "windows" && runtime.GOARCH == "arm",
                runtime.GOOS == "openbsd", // due to -fexecute-only, see #70880
                runtime.GOOS == "aix":
                return errors.New("FIPS 140-3 mode is not supported on " + runtime.GOOS + "-" + runtime.GOARCH)

diff --git a/src/runtime/signal_windows_test.go b/src/runtime/signal_windows_test.go
index 9318ff9c0078805fb9d7e7c6e2b5b5ff53644ad8..7a9afcce2239f4a2ad998888de513866ee6b2723 100644 (file)
--- a/src/runtime/signal_windows_test.go
+++ b/src/runtime/signal_windows_test.go
@@ -79,12 +79,7 @@ func TestVectoredHandlerDontCrashOnLibrary(t *testing.T) {
        if *flagQuick {
                t.Skip("-quick")
        }
-       if runtime.GOARCH == "arm" {
-               //TODO: remove this skip and update testwinlib/main.c
-               // once windows/arm supports c-shared buildmode.
-               // See go.dev/issues/43800.
-               t.Skip("this test can't run on windows/arm")
-       }
+
        testenv.MustHaveGoBuild(t)
        testenv.MustHaveCGO(t)
        testenv.MustHaveExecPath(t, "gcc")
@@ -115,8 +110,8 @@ func TestVectoredHandlerDontCrashOnLibrary(t *testing.T) {
                t.Fatalf("failure while running executable: %s\n%s", err, out)
        }
        var expectedOutput string
-       if runtime.GOARCH == "arm64" || runtime.GOARCH == "arm" {
-               // TODO: remove when windows/arm64 and windows/arm support SEH stack unwinding.
+       if runtime.GOARCH == "arm64" {
+               // TODO: remove when windows/arm64 support SEH stack unwinding.
                expectedOutput = "exceptionCount: 1\ncontinueCount: 1\nunhandledCount: 0\n"
        } else {
                expectedOutput = "exceptionCount: 1\ncontinueCount: 1\nunhandledCount: 1\n"