]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: add position info to sccp debug messages
authorJorropo <jorropo.pgm@gmail.com>
Sat, 25 Oct 2025 20:08:59 +0000 (22:08 +0200)
committerGopher Robot <gobot@golang.org>
Tue, 28 Oct 2025 02:09:34 +0000 (19:09 -0700)
Change-Id: Ic568dd3b2e3ebebb1b6aaa41ee78a12d4e8d3f06
Reviewed-on: https://go-review.googlesource.com/c/go/+/714221
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Jorropo <jorropo.pgm@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
src/cmd/compile/internal/ssa/sccp.go

index 107db23ed4af08b84a1499a6b7e3abe7a17f7e70..9b958d045479c360c520dfc4f692c167d63256f0 100644 (file)
@@ -4,10 +4,6 @@
 
 package ssa
 
-import (
-       "fmt"
-)
-
 // ----------------------------------------------------------------------------
 // Sparse Conditional Constant Propagation
 //
@@ -118,7 +114,7 @@ func sccp(f *Func) {
        constCnt, rewireCnt := t.replaceConst()
        if f.pass.debug > 0 {
                if constCnt > 0 || rewireCnt > 0 {
-                       fmt.Printf("Phase SCCP for %v : %v constants, %v dce\n", f.Name, constCnt, rewireCnt)
+                       f.Warnl(f.Entry.Pos, "Phase SCCP for %v : %v constants, %v dce", f.Name, constCnt, rewireCnt)
                }
        }
 }
@@ -563,7 +559,7 @@ func (t *worklist) replaceConst() (int, int) {
                if lt.tag == constant {
                        if !isConst(val) {
                                if t.f.pass.debug > 0 {
-                                       fmt.Printf("Replace %v with %v\n", val.LongString(), lt.val.LongString())
+                                       t.f.Warnl(val.Pos, "Replace %v with %v", val.LongString(), lt.val.LongString())
                                }
                                val.reset(lt.val.Op)
                                val.AuxInt = lt.val.AuxInt
@@ -575,7 +571,7 @@ func (t *worklist) replaceConst() (int, int) {
                                if rewireSuccessor(block, lt.val) {
                                        rewireCnt++
                                        if t.f.pass.debug > 0 {
-                                               fmt.Printf("Rewire %v %v successors\n", block.Kind, block)
+                                               t.f.Warnl(block.Pos, "Rewire %v %v successors", block.Kind, block)
                                        }
                                }
                        }