]> Cypherpunks repositories - gostls13.git/commitdiff
time: skip TestLongAdjustTimers in short mode on single CPU systems
authorJoel Sing <joel@sing.id.au>
Sat, 23 Aug 2025 05:05:51 +0000 (15:05 +1000)
committerGopher Robot <gobot@golang.org>
Thu, 28 Aug 2025 17:52:45 +0000 (10:52 -0700)
The OpenBSD armv7 port does not support SMP - on this platform the
TestLongAdjustTimers test passes in ~46 seconds on the openbsd/arm
builder when there is no other CPU contention, however it will almost
always fail when there is any other load.

Change-Id: Idf1c47b40376c749886843cdae11289c0984f714
Reviewed-on: https://go-review.googlesource.com/c/go/+/698556
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Commit-Queue: Cherry Mui <cherryyz@google.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/time/tick_test.go

index d89d2dbdeadf2f713dba43a2640e14d5b917e63b..dcbbcdb14509a7bd4cd3b8c29ab2944b956abf9c 100644 (file)
@@ -154,6 +154,10 @@ func TestLongAdjustTimers(t *testing.T) {
        if runtime.GOOS == "android" || runtime.GOOS == "ios" || runtime.GOOS == "plan9" {
                t.Skipf("skipping on %s - too slow", runtime.GOOS)
        }
+       if testing.Short() && runtime.NumCPU() < 2 {
+               t.Skipf("skipping in short mode, insufficient CPUs")
+       }
+
        t.Parallel()
        var wg sync.WaitGroup
        defer wg.Wait()