]> Cypherpunks repositories - gostls13.git/commitdiff
sync/atomic: amend comments for Value.{Swap,CompareAndSwap}
authorJes Cok <xigua67damn@gmail.com>
Wed, 12 Nov 2025 10:35:40 +0000 (10:35 +0000)
committerGopher Robot <gobot@golang.org>
Wed, 12 Nov 2025 18:03:52 +0000 (10:03 -0800)
Related to CL 241661, CL 403094.

Change-Id: I86877d9a013b05b1a97f9aa1333cd96ce98469cb
GitHub-Last-Rev: 7fedca5848cb17730d4ccb586dc03cfcb1b83259
GitHub-Pull-Request: golang/go#76259
Reviewed-on: https://go-review.googlesource.com/c/go/+/719660
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
src/sync/atomic/value.go

index 0cfc5f9496c810465a51af85afedd341f0968185..031a9d5680e5c4907db713b981a1270f6341a8c5 100644 (file)
@@ -98,8 +98,7 @@ func (v *Value) Swap(new any) (old any) {
                if typ == nil {
                        // Attempt to start first store.
                        // Disable preemption so that other goroutines can use
-                       // active spin wait to wait for completion; and so that
-                       // GC does not see the fake type accidentally.
+                       // active spin wait to wait for completion.
                        runtime_procPin()
                        if !CompareAndSwapPointer(&vp.typ, nil, unsafe.Pointer(&firstStoreInProgress)) {
                                runtime_procUnpin()
@@ -150,8 +149,7 @@ func (v *Value) CompareAndSwap(old, new any) (swapped bool) {
                        }
                        // Attempt to start first store.
                        // Disable preemption so that other goroutines can use
-                       // active spin wait to wait for completion; and so that
-                       // GC does not see the fake type accidentally.
+                       // active spin wait to wait for completion.
                        runtime_procPin()
                        if !CompareAndSwapPointer(&vp.typ, nil, unsafe.Pointer(&firstStoreInProgress)) {
                                runtime_procUnpin()