]> Cypherpunks repositories - gostls13.git/commitdiff
runtime/secret: disable tests under memory validating modes
authorDaniel Morsing <daniel.morsing@gmail.com>
Fri, 28 Nov 2025 09:40:00 +0000 (09:40 +0000)
committerGopher Robot <gobot@golang.org>
Fri, 28 Nov 2025 14:15:02 +0000 (06:15 -0800)
These tests rely on reading memory that has been freed, so any of the
modes that validate memory accesses are going to fail. Disable them for
now.

Fixes #76586.

Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-msan-clang15,gotip-linux-amd64-asan-clang15,gotip-linux-amd64-race
Change-Id: I14ee5dfccbafa0e4da684a95ee42acf54499b013
Reviewed-on: https://go-review.googlesource.com/c/go/+/725140
Auto-Submit: Keith Randall <khr@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
src/runtime/secret/secret_test.go

index 7651a93ca5e87316b24068f9f54301bb5301b6ba..98d67cf8a4157f1b3b2e6c5a0a2b5eef4a53d0c1 100644 (file)
@@ -2,10 +2,14 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-// the race detector does not like our pointer shenanigans
-// while checking the stack.
-
-//go:build goexperiment.runtimesecret && (arm64 || amd64) && linux && !race
+// these tests rely on inspecting freed memory, so they
+// can't be run under any of the memory validating modes.
+// TODO: figure out just which test violate which condition
+// and split this file out by individual test cases.
+// There could be some value to running some of these
+// under validation
+
+//go:build goexperiment.runtimesecret && (arm64 || amd64) && linux && !race && !asan && !msan
 
 package secret