]> Cypherpunks repositories - gostls13.git/commitdiff
test/codegen: fix a tab in comparisons.go to ensure pattern works
authorAlexander Musman <alexander.musman@gmail.com>
Sat, 6 Dec 2025 13:43:55 +0000 (21:43 +0800)
committerGopher Robot <gobot@golang.org>
Tue, 30 Dec 2025 15:28:47 +0000 (07:28 -0800)
Fix a pattern in test/codegen/comparisons.go to use whitespace instead
of a tab. The test needs a whitespace to properly fail if the regalloc
change from CL686655 would be missing (in that case we would have a
spill immediately after call to memequal, which is supposed to be
captured by this pattern).

Change-Id: I5b6fb5e861b9327c7f071660592b8ffa265e0030
Reviewed-on: https://go-review.googlesource.com/c/go/+/727620
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
test/codegen/comparisons.go

index bcce21e4044b1271db417cc54088ee57558b0428..0b550adc059956ff3c6f4aaf073abc57b8618e15 100644 (file)
@@ -660,13 +660,13 @@ func equalVarString8(a string) bool {
        return a[:8] == b
 }
 
-func equalVarStringNoSpill(a,b string) bool {
+func equalVarStringNoSpill(a, b string) bool {
        s := string("ZZZZZZZZZ")
        // arm64:".*memequal"
        memeq1 := a[:9] == s
        // arm64:-".*"
        memeq2 := s == a[:9]
-       // arm64:-"MOVB\tR0,.*SP",".*memequal"
+       // arm64:-"MOVB R0,.*SP",".*memequal"
        memeq3 := s == b[:9]
        return memeq1 && memeq2 && memeq3
 }