From: Kevin Burke <kevin@burke.dev>
Date: Tue, 23 Dec 2025 06:07:32 +0000 (-0800)
Subject: time: skip test that will fail with GO111MODULE=off
X-Git-Tag: go1.26rc2~7^2~38
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=08dc8393d7d04f250b317cad5183415962ea56d5;p=gostls13.git

time: skip test that will fail with GO111MODULE=off

The test is designed to ensure that behavior introduced in Go 1.23
to garbage collect async timed channels is working correctly. If
GO111MODULE=off is set (or GODEBUG=asynctimerchan=1) Go reverts to the
Go 1.20 behavior of not garbage collecting these channels, which fails
the test.

Instead of running a test in conditions where we know it will fail,
just skip the test. A more comprehensive test does not make sense
right now because this code may go away soon.

Fixes #76948.

Change-Id: Ib186abd2ea583a06b5c246bfd6df932522cf7f1e
Reviewed-on: https://go-review.googlesource.com/c/go/+/732100
Reviewed-by: Nicholas Husin <husin@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
---

diff --git a/src/time/export_test.go b/src/time/export_test.go
index a4940d12f9..78ce2ad00d 100644
--- a/src/time/export_test.go
+++ b/src/time/export_test.go
@@ -40,6 +40,7 @@ var (
 	Tzset                  = tzset
 	TzsetName              = tzsetName
 	TzsetOffset            = tzsetOffset
+	AsynctimerChan         = asynctimerchan
 )
 
 func LoadFromEmbeddedTZData(zone string) (string, error) {
diff --git a/src/time/tick_test.go b/src/time/tick_test.go
index dcbbcdb145..9b39d28143 100644
--- a/src/time/tick_test.go
+++ b/src/time/tick_test.go
@@ -266,6 +266,10 @@ func BenchmarkTickerResetNaive(b *testing.B) {
 }
 
 func TestTimerGC(t *testing.T) {
+	if AsynctimerChan.Value() == "1" {
+		t.Skip("skipping TestTimerGC with asynctimerchan=1")
+	}
+
 	run := func(t *testing.T, what string, f func()) {
 		t.Helper()
 		t.Run(what, func(t *testing.T) {