From: Michael Pratt <mpratt@google.com>
Date: Tue, 16 Sep 2025 19:07:08 +0000 (-0400)
Subject: runtime: include stderr when objdump fails
X-Git-Tag: go1.26rc1~822
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=9693b94be0;p=gostls13.git

runtime: include stderr when objdump fails

If objdump panics, we want the panic included in the test log.

Change-Id: I6a6a636c13c5ba08acaa1c6c8714541a8e91542b
Reviewed-on: https://go-review.googlesource.com/c/go/+/704338
Reviewed-by: Florian Lehner <lehner.florian86@gmail.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
---

diff --git a/src/runtime/unsafepoint_test.go b/src/runtime/unsafepoint_test.go
index 2c97adead8..79f0171854 100644
--- a/src/runtime/unsafepoint_test.go
+++ b/src/runtime/unsafepoint_test.go
@@ -43,7 +43,7 @@ func TestUnsafePoint(t *testing.T) {
 	cmd := exec.Command(testenv.GoToolPath(t), "tool", "objdump", "-s", "setGlobalPointer", os.Args[0])
 	out, err := cmd.CombinedOutput()
 	if err != nil {
-		t.Fatalf("can't objdump %v", err)
+		t.Fatalf("can't objdump %v:\n%s", err, out)
 	}
 	lines := strings.Split(string(out), "\n")[1:]