From: Daniel Morsing Date: Fri, 28 Nov 2025 09:40:00 +0000 (+0000) Subject: runtime/secret: disable tests under memory validating modes X-Git-Tag: go1.26rc1~40 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=de456450e7;p=gostls13.git runtime/secret: disable tests under memory validating modes These tests rely on reading memory that has been freed, so any of the modes that validate memory accesses are going to fail. Disable them for now. Fixes #76586. Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-msan-clang15,gotip-linux-amd64-asan-clang15,gotip-linux-amd64-race Change-Id: I14ee5dfccbafa0e4da684a95ee42acf54499b013 Reviewed-on: https://go-review.googlesource.com/c/go/+/725140 Auto-Submit: Keith Randall LUCI-TryBot-Result: Go LUCI Reviewed-by: Keith Randall Reviewed-by: Keith Randall Reviewed-by: Carlos Amedee --- diff --git a/src/runtime/secret/secret_test.go b/src/runtime/secret/secret_test.go index 7651a93ca5..98d67cf8a4 100644 --- a/src/runtime/secret/secret_test.go +++ b/src/runtime/secret/secret_test.go @@ -2,10 +2,14 @@ // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. -// the race detector does not like our pointer shenanigans -// while checking the stack. - -//go:build goexperiment.runtimesecret && (arm64 || amd64) && linux && !race +// these tests rely on inspecting freed memory, so they +// can't be run under any of the memory validating modes. +// TODO: figure out just which test violate which condition +// and split this file out by individual test cases. +// There could be some value to running some of these +// under validation + +//go:build goexperiment.runtimesecret && (arm64 || amd64) && linux && !race && !asan && !msan package secret