]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: use the right type for spill slot
authorCherry Mui <cherryyz@google.com>
Tue, 16 Sep 2025 01:27:19 +0000 (21:27 -0400)
committerCherry Mui <cherryyz@google.com>
Fri, 3 Oct 2025 19:30:36 +0000 (12:30 -0700)
commit18cd4a1fc7d5387ae91ffc23328e4fc81f93681d
tree4b8c342fc778db3e1adabcedf4352f80de543ab4
parent1caa95acfa9d516eb3bc26292b5601bea25a4e79
cmd/compile: use the right type for spill slot

Currently, when shuffling registers, if we need to spill a
register, we always create a spill slot of type int64. The type
doesn't actually matter, as long as it is wide enough to hold the
registers. This is no longer true with SIMD registers, which could
be wider than a int64. Create the slot with the proper type
instead.

Cherry-picked from the dev.simd branch. This CL is not
necessarily SIMD specific. Apply early to reduce risk. Test is
SIMD specific so not included for now.

Change-Id: I85c82e2532001bfdefe98c9446f2dd18583d49b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/704055
TryBot-Bypass: Cherry Mui <cherryyz@google.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/708860
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/cmd/compile/internal/ssa/regalloc.go
src/cmd/compile/internal/ssa/value.go