]> Cypherpunks repositories - gostls13.git/commit
[dev.simd] simd: add AES feature check
authorTom Thorogood <me+google@tomthorogood.co.uk>
Sun, 19 Oct 2025 01:21:16 +0000 (11:51 +1030)
committerCherry Mui <cherryyz@google.com>
Mon, 20 Oct 2025 17:32:54 +0000 (10:32 -0700)
commit20b33395428deee4511cb5f595a37d69899455a4
tree61adf7c292624107894831118ff521aa43ebe3b4
parentfc3bc49337be2774a6b38c71fa90dc3a7e716943
[dev.simd] simd: add AES feature check

CL 706055 added AES support but chose to not generate feature checks for
composite features. Intel lists AES as AVXAES which gets manually mapped
to the composite feature AVX, AES. With the previous writeSIMDFeatures
code ignoring composite features, and there being no other references to
AES, we neglected to generate a feature check at all.

To resolve this, we instead split composite features into their
constituent parts and ensure that each feature has a check generated.

Currently AVXAES is the only composite feature.

Updates #73787

Change-Id: Ic8e9d8a3c9c0854fc717512c2ce092d81cb6b66c
Reviewed-on: https://go-review.googlesource.com/c/go/+/712880
Reviewed-by: Junyang Shao <shaojunyang@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/simd/_gen/simdgen/gen_simdTypes.go
src/simd/cpu.go