]> Cypherpunks repositories - gostls13.git/commit
internal/trace: remove redundant info from Event.String
authorFelix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Tue, 19 Aug 2025 15:17:03 +0000 (17:17 +0200)
committerGopher Robot <gobot@golang.org>
Tue, 19 Aug 2025 19:48:42 +0000 (12:48 -0700)
commitb80ffb64d815596eb8882eaefa3e2d2920380634
treea5c334b8a4ffd1f8304d0085e0f6fbfc26722eee
parentc7d8bda4596d2ad4970c8052fded76284b2f0be1
internal/trace: remove redundant info from Event.String

Remove redundant information from state transition events. They
currently mention the proc and goroutine id that is transitioning twice.

Also reorder the reason to appear after the from->to state transition
information since it is a detail that is not available for all
transition.

Before example:

M=6164541440 P=3 G=17 StateTransition Time=7169014471424 Resource=Goroutine(17) Reason="chan receive" GoID=17 Running->Waiting
M=6166261760 P=3 G=10 StateTransition Time=7169908799040 Resource=Proc(4) Reason="" ProcID=4 Idle->Idle

After example:

M=6164541440 P=3 G=17 StateTransition Time=7169014471424 GoID=17 Running->Waiting Reason="chan receive"
M=6166261760 P=3 G=10 StateTransition Time=7169908799040 ProcID=4 Idle->Idle Reason=""

Change-Id: I6a6a696487ff2905f7c98dae7e887b998a2cb298
Reviewed-on: https://go-review.googlesource.com/c/go/+/697356
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
src/internal/trace/event.go