]> Cypherpunks repositories - gostls13.git/commit
runtime: fail TestGoroutineLeakProfile on data race
authorMichael Anthony Knyszek <mknyszek@google.com>
Thu, 9 Oct 2025 20:58:34 +0000 (20:58 +0000)
committerMichael Knyszek <mknyszek@google.com>
Fri, 10 Oct 2025 22:58:20 +0000 (15:58 -0700)
commite8a53538b473f1a7a92602675eda2d34f3887611
tree3f7908dd7a547939dc92fb288a0ab26e20e1636f
parente3be2d1b2b68d960398a343805f77052d5decb22
runtime: fail TestGoroutineLeakProfile on data race

Some of the programs in testdata/testgoroutineleakprofile have data
races because they were taken from a corpus that showcases general Go
concurrency bugs, not just leaked goroutines.

This causes some flakiness as tests might fail due to, for example, a
concurrent map access, even outside of race mode.

Let's just call data races a failure and fix them in the examples. As
far as I can tell, there are only two that show up consistently.

Fixes #75732.

Change-Id: I160b3a1cdce4c2de3f2320b68b4083292e02b557
Reviewed-on: https://go-review.googlesource.com/c/go/+/710756
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/runtime/goroutineleakprofile_test.go
src/runtime/testdata/testgoroutineleakprofile/goker/README.md
src/runtime/testdata/testgoroutineleakprofile/goker/cockroach1055.go
src/runtime/testdata/testgoroutineleakprofile/goker/moby27782.go