From 65ef314f89d7eb8c1a4937edd075127a00da0ecb Mon Sep 17 00:00:00 2001 From: Sean Liao Date: Mon, 17 Nov 2025 19:34:55 +0000 Subject: [PATCH] net/http: remove unused linknames These were removed in: https://github.com/gobwas/ws/commit/8e2d520ba2966517f9c339e36dd89fd8a4460446 For #67401 Change-Id: I44898beb6fa3b6867b3d2164fc930724e143cf30 Reviewed-on: https://go-review.googlesource.com/c/go/+/721200 LUCI-TryBot-Result: Go LUCI Reviewed-by: Damien Neil Reviewed-by: Mark Freeman --- src/net/http/server.go | 36 ------------------------------------ 1 file changed, 36 deletions(-) diff --git a/src/net/http/server.go b/src/net/http/server.go index 2636454958..d63d5bf734 100644 --- a/src/net/http/server.go +++ b/src/net/http/server.go @@ -854,15 +854,6 @@ func bufioWriterPool(size int) *sync.Pool { return nil } -// newBufioReader should be an internal detail, -// but widely used packages access it using linkname. -// Notable members of the hall of shame include: -// - github.com/gobwas/ws -// -// Do not remove or change the type signature. -// See go.dev/issue/67401. -// -//go:linkname newBufioReader func newBufioReader(r io.Reader) *bufio.Reader { if v := bufioReaderPool.Get(); v != nil { br := v.(*bufio.Reader) @@ -874,29 +865,11 @@ func newBufioReader(r io.Reader) *bufio.Reader { return bufio.NewReader(r) } -// putBufioReader should be an internal detail, -// but widely used packages access it using linkname. -// Notable members of the hall of shame include: -// - github.com/gobwas/ws -// -// Do not remove or change the type signature. -// See go.dev/issue/67401. -// -//go:linkname putBufioReader func putBufioReader(br *bufio.Reader) { br.Reset(nil) bufioReaderPool.Put(br) } -// newBufioWriterSize should be an internal detail, -// but widely used packages access it using linkname. -// Notable members of the hall of shame include: -// - github.com/gobwas/ws -// -// Do not remove or change the type signature. -// See go.dev/issue/67401. -// -//go:linkname newBufioWriterSize func newBufioWriterSize(w io.Writer, size int) *bufio.Writer { pool := bufioWriterPool(size) if pool != nil { @@ -909,15 +882,6 @@ func newBufioWriterSize(w io.Writer, size int) *bufio.Writer { return bufio.NewWriterSize(w, size) } -// putBufioWriter should be an internal detail, -// but widely used packages access it using linkname. -// Notable members of the hall of shame include: -// - github.com/gobwas/ws -// -// Do not remove or change the type signature. -// See go.dev/issue/67401. -// -//go:linkname putBufioWriter func putBufioWriter(bw *bufio.Writer) { bw.Reset(nil) if pool := bufioWriterPool(bw.Available()); pool != nil { -- 2.52.0