From 7056c71d320bea2e1cafbb4f8863513ed50a4256 Mon Sep 17 00:00:00 2001 From: David Chase Date: Tue, 14 Oct 2025 16:18:49 -0400 Subject: [PATCH] cmd/compile: disable use of new saturating float-to-int conversions The new conversions can be activated (or bisected) with -gcflags=all=-d=converthash=PATTERN where PATTERN is either a hash string or n, qn, y, qy for no, quietly no, yes, quietly yes. This CL makes the default pattern be "qn" instead of the default-default which is an efficient encoding of "qy". Updates #75834 Change-Id: I88a9fd7880bc999132420c8d0a22a8fdc1e95a2a Reviewed-on: https://go-review.googlesource.com/c/go/+/711845 Reviewed-by: Cherry Mui TryBot-Bypass: David Chase --- src/cmd/compile/internal/base/flag.go | 3 +++ test/codegen/math.go | 2 +- test/convert5.go | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/cmd/compile/internal/base/flag.go b/src/cmd/compile/internal/base/flag.go index 1ac2cecc61..1d211e0a2d 100644 --- a/src/cmd/compile/internal/base/flag.go +++ b/src/cmd/compile/internal/base/flag.go @@ -264,6 +264,9 @@ func ParseFlags() { if Debug.Converthash != "" { ConvertHash = NewHashDebug("converthash", Debug.Converthash, nil) + } else { + // quietly disable the convert hash changes + ConvertHash = NewHashDebug("converthash", "qn", nil) } if Debug.Fmahash != "" { FmaHash = NewHashDebug("fmahash", Debug.Fmahash, nil) diff --git a/test/codegen/math.go b/test/codegen/math.go index 5787657d2b..9ef881a9af 100644 --- a/test/codegen/math.go +++ b/test/codegen/math.go @@ -1,4 +1,4 @@ -// asmcheck +// asmcheck -gcflags=-d=converthash=qy // Copyright 2018 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style diff --git a/test/convert5.go b/test/convert5.go index 1bd74abdad..df247ca0b9 100644 --- a/test/convert5.go +++ b/test/convert5.go @@ -1,4 +1,4 @@ -// run +// run -gcflags=-d=converthash=qy // Copyright 2020 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style -- 2.52.0