From 90c970cd0fce1804d82f5148884e69d179c2e265 Mon Sep 17 00:00:00 2001 From: Plamerdi Makela Date: Tue, 11 Nov 2025 15:10:53 +0000 Subject: [PATCH] net: remove unnecessary loop variable copies in tests Similar to CL 711640. Change-Id: I5cd9470138c80094eeb497cf4652d6a29cd795a6 GitHub-Last-Rev: 603fb5f4d55a12a773f2cb08b295578fb45ad14e GitHub-Pull-Request: golang/go#76253 Reviewed-on: https://go-review.googlesource.com/c/go/+/719600 Auto-Submit: Damien Neil Reviewed-by: Mark Freeman LUCI-TryBot-Result: Go LUCI Reviewed-by: Damien Neil --- src/net/lookup_windows_test.go | 2 -- src/net/unixsock_windows_test.go | 1 - src/net/url/url_test.go | 1 - 3 files changed, 4 deletions(-) diff --git a/src/net/lookup_windows_test.go b/src/net/lookup_windows_test.go index 4f28790185..bee1a6150c 100644 --- a/src/net/lookup_windows_test.go +++ b/src/net/lookup_windows_test.go @@ -30,9 +30,7 @@ func toJson(v any) string { func testLookup(t *testing.T, fn func(*testing.T, *Resolver, string)) { for _, def := range []bool{true, false} { - def := def for _, server := range nslookupTestServers { - server := server var name string if def { name = "default/" diff --git a/src/net/unixsock_windows_test.go b/src/net/unixsock_windows_test.go index 4c1a8d7e7e..b7ed932b14 100644 --- a/src/net/unixsock_windows_test.go +++ b/src/net/unixsock_windows_test.go @@ -20,7 +20,6 @@ func TestUnixConnLocalWindows(t *testing.T) { } handler := func(ls *localServer, ln Listener) {} for _, laddr := range []string{"", testUnixAddr(t)} { - laddr := laddr taddr := testUnixAddr(t) ta, err := ResolveUnixAddr("unix", taddr) if err != nil { diff --git a/src/net/url/url_test.go b/src/net/url/url_test.go index a70b94b424..3ced91fc4c 100644 --- a/src/net/url/url_test.go +++ b/src/net/url/url_test.go @@ -880,7 +880,6 @@ func TestURLRedacted(t *testing.T) { } for _, tt := range cases { - t := t t.Run(tt.name, func(t *testing.T) { if g, w := tt.url.Redacted(), tt.want; g != w { t.Fatalf("got: %q\nwant: %q", g, w) -- 2.52.0