From a33bbf1988685215cdf300feb47d2e356e459b3e Mon Sep 17 00:00:00 2001 From: cuishuang Date: Mon, 24 Nov 2025 14:38:30 +0800 Subject: [PATCH] weak: fix weak pointer test to correctly iterate over weak pointers after GC This change fixes a bug in the weak pointer test where the loop was attempting to iterate over a nil slice (bt) instead of the weak pointer slice (wt). After setting bt to nil and running GC, the test should iterate over the weak pointers to verify they've been cleared, not attempt to iterate over the now-nil strong references. Change-Id: Ic0425f59da132257770ed87d1bcea5d2c0a54e07 Reviewed-on: https://go-review.googlesource.com/c/go/+/723600 Reviewed-by: David Chase LUCI-TryBot-Result: Go LUCI Reviewed-by: Dmitri Shuralyov Reviewed-by: Sean Liao --- src/weak/pointer_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/weak/pointer_test.go b/src/weak/pointer_test.go index 5e8b9bef58..b497c702af 100644 --- a/src/weak/pointer_test.go +++ b/src/weak/pointer_test.go @@ -110,7 +110,7 @@ func TestPointerEquality(t *testing.T) { bt = nil // bt is no longer referenced. runtime.GC() - for i := range bt { + for i := range wt { st := wt[i].Value() if st != nil { t.Fatalf("expected weak pointer to be nil, got %p", st) -- 2.52.0