From ccd389036a7ba67f456d4185f4103fe233f6e551 Mon Sep 17 00:00:00 2001 From: Dmitri Shuralyov Date: Fri, 14 Nov 2025 13:00:28 -0500 Subject: [PATCH] cmd/internal/objabi: remove -V=goexperiment internal special case This special case was added in CL 310171 for test/run.go use, as the comment still says, but run.go (cmd/internal/testdir/testdir_test.go by now) stopped using this in CL 310732. There don't seem to be any other internal or external uses of this special case, so delete it. Doing this kind of a cleanup can become harder as more time passes, so try it as early as now and see how it goes. Change-Id: Ib52aac51ef05166f7349cfc7d63b860a8ece7ec0 Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/720620 Auto-Submit: Dmitri Shuralyov Reviewed-by: Dmitri Shuralyov Reviewed-by: Michael Matloob Reviewed-by: Michael Matloob LUCI-TryBot-Result: Go LUCI --- src/cmd/internal/objabi/flag.go | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/cmd/internal/objabi/flag.go b/src/cmd/internal/objabi/flag.go index 32d71d0575..603bf8746c 100644 --- a/src/cmd/internal/objabi/flag.go +++ b/src/cmd/internal/objabi/flag.go @@ -95,16 +95,10 @@ func (versionFlag) Set(s string) error { p := "" - if s == "goexperiment" { - // test/run.go uses this to discover the full set of - // experiment tags. Report everything. - p = " X:" + strings.Join(buildcfg.Experiment.All(), ",") - } else { - // If the enabled experiments differ from the baseline, - // include that difference. - if goexperiment := buildcfg.Experiment.String(); goexperiment != "" { - p = " X:" + goexperiment - } + // If the enabled experiments differ from the baseline, + // include that difference. + if goexperiment := buildcfg.Experiment.String(); goexperiment != "" { + p = " X:" + goexperiment } // The go command invokes -V=full to get a unique identifier -- 2.52.0