]> Cypherpunks repositories - gostls13.git/commit
internal/syscall/windows/registry: fix strict assumptions in TestWalkFullRegistry
authorJason A. Donenfeld <Jason@zx2c4.com>
Tue, 22 Oct 2019 20:39:30 +0000 (22:39 +0200)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 23 Oct 2019 03:08:00 +0000 (03:08 +0000)
commit0195a29399946210700bc5dca2d55c75d80ef9ff
treea4d0ac5853cf5f83a34e24c1927a1192dc65819e
parentdded58760d3e97907d9ee2d5c7b0252970508044
internal/syscall/windows/registry: fix strict assumptions in TestWalkFullRegistry

It turns out that Windows has "legitimate" keys that have bogus type
values or bogus lengths that don't correspond with their type. On up to
date Windows 10 systems, this test always fails for this reason.

So, this commit alters the test to simply log the discrepancy and move
on.

Fixes #35084

Change-Id: I56e12cc62aff49cfcc38ff01a19dfe53153976a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/202678
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/internal/syscall/windows/registry/registry_test.go