]> Cypherpunks repositories - gostls13.git/commit
archive/tar: forbid NUL character in string fields
authorJoe Tsai <joetsai@digital-static.net>
Thu, 17 Sep 2015 23:39:37 +0000 (16:39 -0700)
committerJoe Tsai <thebrokentoaster@gmail.com>
Fri, 11 Aug 2017 03:12:47 +0000 (03:12 +0000)
commit019d8a07e102bd0047a70d026986d7c02781e26f
treefd1684243a0385e9c738774a51e3ad83af8e042b
parentc592c05745f42874d205430261c0bda37a272b55
archive/tar: forbid NUL character in string fields

USTAR and GNU strings are NUL-terminated. Thus, we should never
allow the NUL terminator, otherwise we will lose data round-trip.

Relevant specification text:
<<<
The fields magic, uname, and gname are character strings each terminated by a NUL character.
>>>

Technically, PAX keys and values should be UTF-8, but the observance
of invalid files in the wild causes us to be more liberal.
<<<
The <length> field, <blank>, <equals-sign>, and <newline> shown shall
be limited to the portable character set, as encoded in UTF-8.
>>>

Thus, we only reject NULs in PAX keys, and NULs for PAX values
representing the USTAR string fields (i.e., path, linkpath, uname, gname).
These are treated more strictly because they represent strings that
are typically represented as C-strings on POSIX systems.

Change-Id: I305b794d9d966faad852ff660bd0b3b0964e52bf
Reviewed-on: https://go-review.googlesource.com/14724
Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/archive/tar/reader_test.go
src/archive/tar/strconv.go
src/archive/tar/strconv_test.go
src/archive/tar/testdata/gnu-long-nul.tar [new file with mode: 0644]
src/archive/tar/testdata/pax-nul-path.tar [new file with mode: 0644]
src/archive/tar/testdata/pax-nul-xattrs.tar [new file with mode: 0644]
src/archive/tar/writer.go
src/archive/tar/writer_test.go