]> Cypherpunks repositories - gostls13.git/commit
time: prevent a panic from leaving the timer mutex held
authorJeff R. Allen <jra@nella.org>
Tue, 2 Jul 2013 01:42:29 +0000 (21:42 -0400)
committerRuss Cox <rsc@golang.org>
Tue, 2 Jul 2013 01:42:29 +0000 (21:42 -0400)
commit0286b4738e33c5a043d454b23af88fb95127bf13
tree0cc84369d61ac8066eedbfdfaf9e03249b5d0561
parentb86f6c92247bc453fff28956d0ef0420b8b96f21
time: prevent a panic from leaving the timer mutex held

When deleting a timer, a panic due to nil deref
would leave a lock held, possibly leading to a deadlock
in a defer. Instead return false on a nil timer.

Fixes #5745.

R=golang-dev, daniel.morsing, dvyukov, rsc, iant
CC=golang-dev
https://golang.org/cl/10373047
src/pkg/runtime/time.goc
src/pkg/time/sleep_test.go