]> Cypherpunks repositories - gostls13.git/commit
internal/syscall/windows/registry: blacklist certain registry keys in TestWalkFullReg...
authorJason A. Donenfeld <Jason@zx2c4.com>
Tue, 22 Oct 2019 20:39:30 +0000 (22:39 +0200)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 23 Oct 2019 21:20:18 +0000 (21:20 +0000)
commit033e066cb3fc06c1c8eeb3033438e1be8770d100
tree3f9d5ba7e855f5ae8d798ce3b3cfa9848682d968
parentb284dac23250a2c0ad941d6e20de7d54ffa13253
internal/syscall/windows/registry: blacklist certain registry keys in TestWalkFullRegistry

It turns out that Windows has "legitimate" keys that have bogus type
values or bogus lengths that don't correspond with their type. On up to
date Windows 10 systems, this test always fails for this reason. These
keys exist because of bugs in Microsoft's code. This commit works around
the problem by simply blacklisting known instances. It also expands the
error message a bit so that we can make adjustments should the problem
ever happen again, and reformats the messages so that it makes copy and
pasting into the blacklist easier.

Updates #35084

Change-Id: I50322828c0eb0ccecbb62d6bf4f9c726fa0b3c27
Reviewed-on: https://go-review.googlesource.com/c/go/+/202897
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/internal/syscall/windows/registry/registry_test.go