]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.13] cmd/compile/internal/ssa: skip TestNexting with old Delve...
authorDmitri Shuralyov <dmitshur@golang.org>
Fri, 12 Jun 2020 02:02:27 +0000 (22:02 -0400)
committerDmitri Shuralyov <dmitshur@golang.org>
Fri, 12 Jun 2020 18:56:48 +0000 (18:56 +0000)
commit034ed8089d057349032fb56a3c827ab51789c712
treeb95abfad5e6d158070a023156ad7febad7cb2e8c
parent6be4a5eb4898c7b5e7557dda061cc09ba310698b
[release-branch.go1.13] cmd/compile/internal/ssa: skip TestNexting with old Delve on linux/386

Support for linux/386 was added to Delve in version 1.4.1, but the
version of Delve currently installed on the linux-386-longtest
builder is 1.2.0. That isn't new enough, which causes the test
to fail. Skip it on that builder until it can be made to work.

The only reason it used to pass on the linux-386-longtest builder
before is because that builder was misconfigured to run tests for
linux/amd64. This was resolved in CL 234520.

Also improve internal documentation and the text of skip reasons.

For #39309.
Fixes #39561.

Change-Id: I395cb1f076e59dd3a3feb53e1dcdce5101e9a0f5
Reviewed-on: https://go-review.googlesource.com/c/go/+/237617
Reviewed-by: David Chase <drchase@google.com>
src/cmd/compile/internal/ssa/debug_test.go