]> Cypherpunks repositories - gostls13.git/commit
sync: deflake TestWaitGroupMisuse3
authorBrad Fitzpatrick <bradfitz@golang.org>
Wed, 3 Feb 2016 16:58:43 +0000 (16:58 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 3 Feb 2016 20:03:32 +0000 (20:03 +0000)
commit03f42ee3a561100f99bd98c3a52780536a422ab7
tree21c93964903d79ba81207191db867f14f9ce63fc
parent0ed70efc6b7ec096603c58f27c2668af3862bb3c
sync: deflake TestWaitGroupMisuse3

Previous flakes:
https://build.golang.org/log/223365dedb6b6aa0cfdf5afd0a50fd433a16bade
https://build.golang.org/log/edbea4cd3f24e707ef2ae8378559bb0fcc453c22

Dmitry says in email about this:

> The stack trace points to it pretty clearly. Done can indeed unblock
> Wait first and then panic. I guess we need to recover after first
> Done as well.

And it looks like TestWaitGroupMisuse2 was already hardened against
this.  Do the same in TestWaitGroupMisuse3.

Change-Id: I317800c7e46f13c97873f0873c759a489dd5f47d
Reviewed-on: https://go-review.googlesource.com/19183
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/sync/waitgroup_test.go