]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix corner case in DWARF inline info generation
authorThan McIntosh <thanm@google.com>
Tue, 19 Dec 2017 17:08:32 +0000 (12:08 -0500)
committerThan McIntosh <thanm@google.com>
Tue, 19 Dec 2017 19:00:42 +0000 (19:00 +0000)
commit044721631659c2f0bcf3219462fdc20498b9954c
tree90262f764d10e240be01f4076385606bccf739b2
parent3aeb3950a9eb02b7d07e68b8b3535540854951e0
cmd/compile: fix corner case in DWARF inline info generation

The helper routine for returning pre-inlining parameter declarations
wasn't properly handling the case where you have more than one
parameter named "_" in a function signature; this triggered a map
collision later on when the function was inlined and DWARF was
generated for the inlined routine instance.

Fixes #23179.

Change-Id: I12e5d6556ec5ce08e982a6b53666a4dcc1d22201
Reviewed-on: https://go-review.googlesource.com/84755
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/compile/internal/gc/pgen.go
test/fixedbugs/issue23179.dir/a.go [new file with mode: 0644]
test/fixedbugs/issue23179.dir/b.go [new file with mode: 0644]
test/fixedbugs/issue23179.go [new file with mode: 0644]