]> Cypherpunks repositories - gostls13.git/commit
http: remove finalURL from Client.Get; move to Response
authorBrad Fitzpatrick <bradfitz@golang.org>
Fri, 13 May 2011 14:31:24 +0000 (07:31 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 13 May 2011 14:31:24 +0000 (07:31 -0700)
commit05a1b7ec4139f0b6affd4ac0b2dcb28dec8825b6
treee8831c813c8d7276c414e45bfd5531de470f0617
parent4336116d3b9bc89b48d78260ff2dc9dad0961458
http: remove finalURL from Client.Get; move to Response

This CL:

-- removes Response.RequestMethod string
-- adds Response.Request *Request
-- removes the finalURL result parameter from client.Get()
-- adds a gofix rule for callers of http.Get which assign
   the final url to the blank identifier; warning otherwise

Caller who did:

res, finalURL, err := http.Get(...)

now need to do:

res, err := http.Get(...)
if err != nil {
   ...
}
finalURL := res.Request.URL.String()

R=rsc
CC=golang-dev
https://golang.org/cl/4535056
22 files changed:
doc/codelab/wiki/get.go
misc/dashboard/builder/http.go
src/cmd/godoc/main.go
src/cmd/gofix/Makefile
src/cmd/gofix/httpfinalurl.go [new file with mode: 0644]
src/cmd/gofix/httpfinalurl_test.go [new file with mode: 0644]
src/pkg/http/client.go
src/pkg/http/client_test.go
src/pkg/http/fs_test.go
src/pkg/http/persist.go
src/pkg/http/request_test.go
src/pkg/http/response.go
src/pkg/http/response_test.go
src/pkg/http/responsewrite_test.go
src/pkg/http/reverseproxy_test.go
src/pkg/http/serve_test.go
src/pkg/http/transfer.go
src/pkg/http/transport.go
src/pkg/http/transport_test.go
src/pkg/rpc/client.go
src/pkg/websocket/client.go
src/pkg/websocket/websocket_test.go