]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.11] cmd/go: ensure git attributes are set
authorJason Keene <jasonkeene@gmail.com>
Thu, 13 Sep 2018 02:35:58 +0000 (20:35 -0600)
committerBryan C. Mills <bcmills@google.com>
Wed, 24 Oct 2018 21:47:37 +0000 (21:47 +0000)
commit05b2b9b4d5cf5f6e34d0edecf497dd0b00dc8f07
tree467334b0aa733f7e984e87bddbc17d15d77c2242
parent844bb04531c5222d4c087392a50fb5ba3b1e2e11
[release-branch.go1.11] cmd/go: ensure git attributes are set

This change disables the export-subst and export-ignore attributes when
creating zip files for modules. This is done to prevent the ziphash for
a given repo/revision from differing based on variables such as git
version or size of repo. The full rational for this change is detailed
here:

    https://github.com/golang/go/issues/27153#issuecomment-420763082

Fixes #28094

Change-Id: Ib33f525d91d2581fa0b5d26e70d29620c7e685e9
Reviewed-on: https://go-review.googlesource.com/c/135175
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-on: https://go-review.googlesource.com/c/141098
Reviewed-by: Andrew Bonventre <andybons@golang.org>
src/cmd/go/internal/modfetch/codehost/git.go
src/cmd/go/testdata/script/mod_git_export_subst.txt [new file with mode: 0644]