]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.15] cmd/compile: fix storeType to handle pointers to go:notinheap...
authorKeith Randall <khr@golang.org>
Thu, 22 Oct 2020 20:11:16 +0000 (13:11 -0700)
committerIan Lance Taylor <iant@golang.org>
Tue, 27 Oct 2020 23:05:53 +0000 (23:05 +0000)
commit068911e1dd7742939ae567d7bff30c9116c9c365
treeaa67ec1ea7fcf8283aad6ada29089b12ee8ef8db
parent255afa2461eb45756bbc562d37f5988cc3ca29f7
[release-branch.go1.15] cmd/compile: fix storeType to handle pointers to go:notinheap types

storeType splits compound stores up into a scalar parts and a pointer parts.
The scalar part happens unconditionally, and the pointer part happens
under the guard of a write barrier check.

Types which are declared as pointers, but are represented as scalars because
they might have "bad" values, were not handled correctly here. They ended
up not getting stored in either set.

Fixes #42151

Change-Id: I46f6600075c0c370e640b807066247237f93c7ac
Reviewed-on: https://go-review.googlesource.com/c/go/+/264300
Trust: Keith Randall <khr@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 933721b8c7f981229974e2603850c2e9a7ffc5a1)
Reviewed-on: https://go-review.googlesource.com/c/go/+/265719
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
src/cmd/compile/internal/gc/ssa.go
test/fixedbugs/issue42032.go [new file with mode: 0644]