]> Cypherpunks repositories - gostls13.git/commit
runtime: make runtime.GC() trigger GC even if GOGC=off
authorAustin Clements <austin@google.com>
Mon, 25 Sep 2017 18:58:13 +0000 (14:58 -0400)
committerAustin Clements <austin@google.com>
Tue, 26 Sep 2017 21:55:05 +0000 (21:55 +0000)
commit0744c21b98e916470c97ff5816630398cf3213c8
treedaad80ad7ed26808c44948209300828a0ad9ab55
parent382d4928b8a758a91f06de9e6cb10b92bb882eff
runtime: make runtime.GC() trigger GC even if GOGC=off

Currently, the priority of checks in (gcTrigger).test() puts the
gcpercent<0 test above gcTriggerCycle, which is used for runtime.GC().
This is an unintentional change from 1.8 and before, where
runtime.GC() triggered a GC even if GOGC=off.

Fix this by rearranging the priority so the gcTriggerCycle test
executes even if gcpercent < 0.

Fixes #22023.

Change-Id: I109328d7b643b6824eb9d79061a9e775f0149575
Reviewed-on: https://go-review.googlesource.com/65994
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rick Hudson <rlh@golang.org>
src/runtime/gc_test.go
src/runtime/mgc.go