]> Cypherpunks repositories - gostls13.git/commit
go/token: fix data race on FileSet.last
authorDave Cheney <dave@cheney.net>
Wed, 19 Dec 2012 21:26:24 +0000 (08:26 +1100)
committerDave Cheney <dave@cheney.net>
Wed, 19 Dec 2012 21:26:24 +0000 (08:26 +1100)
commit07e706f8ce98e3701998afdc18bb62dac324fb2a
tree620e11f6849e978c61584f3a031578eee26794a8
parent4e406a2372b65ce58b2c4d26ada1c8b27c791af8
go/token: fix data race on FileSet.last

Fixes #4345.

Benchmarks are promising,

benchmark         old ns/op    new ns/op    delta
BenchmarkPrint     14716391     14747131   +0.21%

benchmark         old ns/op    new ns/op    delta
BenchmarkParse      8846219      8809343   -0.42%

benchmark          old MB/s     new MB/s  speedup
BenchmarkParse         6.61         6.64    1.00x

Also includes additional tests to improve token.FileSet coverage.

R=dvyukov, gri
CC=golang-dev
https://golang.org/cl/6968044
src/pkg/go/token/position.go
src/pkg/go/token/position_test.go