]> Cypherpunks repositories - gostls13.git/commit
cmd/link: put runtime.framepointer_enabled in DATA instead of RODATA
authorCherry Zhang <cherryyz@google.com>
Wed, 4 Apr 2018 16:12:10 +0000 (12:12 -0400)
committerCherry Zhang <cherryyz@google.com>
Wed, 4 Apr 2018 16:37:20 +0000 (16:37 +0000)
commit08304e886790cbf0ef4bca8158dcb7d99f3a67e7
tree96aa0faec1dcb0dff92bee1c3f5ebed9b9b7de0f
parent73e0c302b2bcf26c009f682c2c11ef3567854d46
cmd/link: put runtime.framepointer_enabled in DATA instead of RODATA

On darwin, only writable symbol is exported
(cmd/link/internal/ld/macho.go:/machoShouldExport).
For plugin to work correctly, global variables, including
runtime.framepointer_enabled which is set by the linker, need
to be exported when dynamic linking. Put it in DATA so it is
exported. Also in Go it is defined as a var, which is not
read-only.

While here, do the same for runtime.goarm.

Fixes #24653.

Change-Id: I9d1b7d5a648be17103d20b97be65a901cb69f5a2
Reviewed-on: https://go-review.googlesource.com/104715
Run-TryBot: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
src/cmd/link/internal/ld/lib.go