]> Cypherpunks repositories - gostls13.git/commit
cmd/go: fix go command fails to perform concurrent compilation
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Mon, 20 Sep 2021 17:23:28 +0000 (00:23 +0700)
committerCuong Manh Le <cuong.manhle.vn@gmail.com>
Wed, 22 Sep 2021 03:36:42 +0000 (03:36 +0000)
commit085c609a70f8f156734efe2cf4bfb5fe8bd94363
tree4ae29b239292887e04cf1b105b4fef82df5fd0b9
parent3664950ef68089716b9f22062db66a347c7246d4
cmd/go: fix go command fails to perform concurrent compilation

CL 344909 fixed the bug in the order of passing gcflags from cmd/go to
cmd/compile. In that process, we merged the flags passed by cmd/go and
the flags specified by "-gcflags" to one variable. That causes the
gcBackendConcurrency function fails to detect concurrency level, since
when it expects only the latter flags.

To fix this, just don't merge those two variables, so we can now
correctly detect the concurrency level and passing the right -c to
the compiler.

Fixes #48490

Change-Id: I1293a7d6b946b7fccdd5cd34a38452bf6306e115
Reviewed-on: https://go-review.googlesource.com/c/go/+/351049
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/cmd/go/internal/work/gc.go
src/cmd/go/testdata/script/build_concurrent_backend.txt [new file with mode: 0644]