]> Cypherpunks repositories - gostls13.git/commit
cmd/go/internal/mvs: prune spurious dependencies in Downgrade
authorBryan C. Mills <bcmills@google.com>
Fri, 19 Feb 2021 19:03:45 +0000 (14:03 -0500)
committerBryan C. Mills <bcmills@google.com>
Tue, 2 Mar 2021 17:08:12 +0000 (17:08 +0000)
commit09f4ef4fa73a110eefd2cb9d78439f51d9294f65
tree962ddb489449a720968b070ed207d21529748a85
parentc6374f516206c02b905d0d76ee1a66dab6fcd212
cmd/go/internal/mvs: prune spurious dependencies in Downgrade

Previously, mvs.Downgrade could introduce spurious dependencies if the
downgrade computed for one module lands on a “hidden” version (such as
a pseudo-version) due to a requirement introduced by the downgrade for
another module.

To eliminate those spurious dependencies, we can add one more call to
BuildList to recompute the “actual” downgraded versions, and then
including only those actual versions in the final call to BuildList.

For #36460

Change-Id: Icc6b54aa004907221b2bcbbae74598b0e4100776
Reviewed-on: https://go-review.googlesource.com/c/go/+/294294
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
src/cmd/go/internal/mvs/mvs.go
src/cmd/go/internal/mvs/mvs_test.go
src/cmd/go/testdata/script/mod_get_downup_pseudo_artifact.txt