]> Cypherpunks repositories - gostls13.git/commit
runtime/pprof: assert that labelHog samples are always labeled
authorMichael Pratt <mpratt@google.com>
Mon, 6 Dec 2021 22:26:32 +0000 (17:26 -0500)
committerMichael Pratt <mpratt@google.com>
Tue, 7 Dec 2021 22:33:39 +0000 (22:33 +0000)
commit0a15e7851a0ea1ebe1523bb70a6cfe56488ea2ef
tree504afb79b608b56884a98ebfa8141a74220c0fa1
parenta3ae45ebe1b3576428f5eb27347704b2d099eab0
runtime/pprof: assert that labelHog samples are always labeled

With https://golang.org/issue/50007 resolved, there are no known issues
with pprof labels remaining. Thus, the 10% allowed error in
TestLabelSystemstack should not be required.

Drop it in favor of an explicit assertion that all samples containing
labelHog are properly labeled.

This is no flaky in my local testing. It is possible that other bugs
will appear at larger testing scale, in which case this CL will be
reverted, but then at least we will be aware of additional failure
modes.

For #50007.

Change-Id: I1ef530c303bd9a01af649b8b08d4b35505e8aada
Reviewed-on: https://go-review.googlesource.com/c/go/+/369744
Reviewed-by: Bryan Mills <bcmills@google.com>
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/runtime/pprof/pprof_test.go