]> Cypherpunks repositories - gostls13.git/commit
runtime: no SIGWINCH to pgrp while GDB is running
authorMichael Pratt <mpratt@google.com>
Fri, 29 May 2020 20:01:17 +0000 (16:01 -0400)
committerMichael Pratt <mpratt@google.com>
Fri, 29 May 2020 21:18:16 +0000 (21:18 +0000)
commit0aed2a4133d4a6cbefa9f86096500009bacc8e4c
treed417fd338e6ada2a3a1487d5ffc532b02f444771
parent6ad5f4e334a7b2cecf319d7f4aecfaa8d790395e
runtime: no SIGWINCH to pgrp while GDB is running

When run with stdin == /dev/null and stdout/stderr == pipe (i.e., as
os/exec.Command.CombinedOutput), GDB suffers from a bug
(https://sourceware.org/bugzilla/show_bug.cgi?id=26056) that causes
SIGSEGV when sent a SIGWINCH signal.

Package runtime tests TestEINTR and TestSignalDuringExec both send
SIGWINCH signals to the entire process group, thus including GDB if one
of the GDB tests is running in parallel.

TestEINTR only intends its signals for the current process, so it is
changed to do so. TestSignalDuringExec, really does want its signals to
go to children. However, it does not call t.Parallel(), so it won't run
at the same time as GDB tests.

This is a simple fix, but GDB is vulnerable, so we must be careful not
to add new parallel tests that send SIGWINCH to the entire process
group.

Fixes #39021

Change-Id: I803606fb000f08c65c1b10ec554d4ef6819e5dd5
Reviewed-on: https://go-review.googlesource.com/c/go/+/235557
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/runtime/runtime-gdb_test.go
src/runtime/testdata/testprogcgo/eintr.go