]> Cypherpunks repositories - gostls13.git/commit
runtime: profile contended lock calls
authorRhys Hiltner <rhys@justin.tv>
Tue, 12 Sep 2023 22:44:48 +0000 (15:44 -0700)
committerGopher Robot <gobot@golang.org>
Fri, 17 Nov 2023 23:04:58 +0000 (23:04 +0000)
commit0b31a46f1fd89b1ede02be9fae920dca6172ffaf
tree0c0d678c264702d0b844e926a5f6ed2bc03b3dc8
parent3cdc2a13b9cc84b74c6914df1a50907f9410e772
runtime: profile contended lock calls

Add runtime-internal locks to the mutex contention profile.

Store up to one call stack responsible for lock contention on the M,
until it's safe to contribute its value to the mprof table. Try to use
that limited local storage space for a relatively large source of
contention, and attribute any contention in stacks we're not able to
store to a sentinel _LostContendedLock function.

Avoid ballooning lock contention while manipulating the mprof table by
attributing to that sentinel function any lock contention experienced
while reporting lock contention.

Guard collecting real call stacks with GODEBUG=profileruntimelocks=1,
since the available data has mixed semantics; we can easily capture an
M's own wait time, but we'd prefer for the profile entry of each
critical section to describe how long it made the other Ms wait. It's
too late in the Go 1.22 cycle to make the required changes to
futex-based locks. When not enabled, attribute the time to the sentinel
function instead.

Fixes #57071

Change-Id: I3eee0ccbfc20f333b56f20d8725dfd7f3a526b41
Reviewed-on: https://go-review.googlesource.com/c/go/+/528657
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Rhys Hiltner <rhys@justin.tv>
Reviewed-by: Than McIntosh <thanm@google.com>
src/runtime/debug.go
src/runtime/export_test.go
src/runtime/extern.go
src/runtime/lock_futex.go
src/runtime/lock_sema.go
src/runtime/metrics.go
src/runtime/metrics_test.go
src/runtime/mprof.go
src/runtime/proc.go
src/runtime/runtime1.go
src/runtime/runtime2.go