]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.15] runtime: implement StorepNoWB for wasm in assembly
authorKeith Randall <khr@golang.org>
Sun, 23 Aug 2020 18:52:53 +0000 (11:52 -0700)
committerDmitri Shuralyov <dmitshur@golang.org>
Fri, 9 Oct 2020 17:23:13 +0000 (17:23 +0000)
commit0b80775b8fb2f08d0cb9a673f13eb30ec17372d3
tree8e2cf00e4c045a46b9fde1f566706b1311dc350f
parent2c2e11f34595669c118fcfd3fe9de562e00b71df
[release-branch.go1.15] runtime: implement StorepNoWB for wasm in assembly

The second argument of StorepNoWB must be forced to escape.
The current Go code does not explicitly enforce that property.
By implementing in assembly, and not using go:noescape, we
force the issue.

Test is in CL 249761. Issue #40975.

This CL is needed for CL 249917, which changes how go:notinheap
works and breaks the previous StorepNoWB wasm code.

I checked for other possible errors like this. This is the only
go:notinheap that isn't in the runtime itself.

Included test from CL 249761.

Update #41432

Change-Id: I43400a806662655727c4a3baa8902b63bdc9fa57
Reviewed-on: https://go-review.googlesource.com/c/go/+/249962
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
(cherry picked from commit c0602603b20186228b4f89f265cb3f7665e06768)
Reviewed-on: https://go-review.googlesource.com/c/go/+/260878
Trust: Keith Randall <khr@golang.org>
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
src/runtime/internal/atomic/asm_wasm.s [new file with mode: 0644]
src/runtime/internal/atomic/atomic_test.go
src/runtime/internal/atomic/atomic_wasm.go